Re: [PULL] gspca

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 26 Jan 2009 10:40:35 +0100
Jean-Francois Moine <moinejf@xxxxxxx> wrote:

> Hi Mauro,
> 
> (there may be a conflict with the changeset 10313:b1a8e8ab7a2a)
> 
> Please pull from http://linuxtv.org/hg/~jfrancois/gspca/
> for:

Pulled, thanks.

Please avoid sending me a very long series like this. Makes harder for me to
review and may hold your pull request. It is better to send more frequent patches.

> 
> changeset:   10164:6f3948c174c1
> gspca - stv06xx: Rework control description.

+                       .id             = V4L2_CTRL_CLASS_USER + 0x1000,
+                       .type           = V4L2_CTRL_TYPE_INTEGER,
+                       .name           = "Automatic Gain Target",

+                       .id             = V4L2_CTRL_CLASS_USER + 0x1001,
+                       .type           = V4L2_CTRL_TYPE_BOOLEAN,
+                       .name           = "Natural Light Source",

This patch is just moving the control from one file to another. That's ok, but
I noticed that this driver is using some user-defined controls. You should
instead discuss about such controls before adding, since we should try to
standardize the control names and ID's over all drivers.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux