On Tue, 20 Jan 2009, Thierry Merle wrote: > Mauro Carvalho Chehab a écrit : > > On Sat, 17 Jan 2009 19:09:51 +0100 > > Carsten Meier <cm@xxxxxxxxxx> wrote: > > > >> Am Fri, 16 Jan 2009 02:47:50 -0200 > >> schrieb Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>: > >> > >>> For usb devices, usb_make_path() provide a canonical name for the > >>> device. For PCI ones, we have pci_name() for the same function. in > >>> the case of pci devices, I suspect that all use pci_name(). We just > >>> need to use usb_make_path() at the usb ones. > >>> > >> I looked at the sources for what string gets generated for bus_info by > >> usb_make_path(). If it gets used by pvrusb2, my problems are solved, > >> because it is constant across standby-wake-up-cycles. The pvrusb2's > >> implementation currently delivers "usb 7-2 address 6" here. "address > >> 6" corresponds to devnum which gets constantly increased, which results > >> in always changing strings here. Sorry for my unneccessary complaints. > > > > Mike, Thierry, Jean-Francois, Laurent and others: > > > > IMO, we should patch all usb drivers to use usb_make_path(). It will be more > > transparent to userspace, if all drivers provide the bus_info using the same > > notation. Comments? > > > In fact the usbvision code was reporting already a portable information using dev_name. > strlcpy(vc->bus_info, dev_name(&usbvision->dev->dev), > sizeof(vc->bus_info)); > changed to: > usb_make_path(usbvision->dev, vc->bus_info, sizeof(vc->bus_info)); > shows the same information on my system. > It is simpler so I am OK with this change. > Do you want us to make separate patch or did you start a global patch? > Cheers, > Thierry I will update the pvrusb2 driver. -Mike -- Mike Isely isely @ pobox (dot) com PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
