Re: [PULL] http://linuxtv.org/hg/~mcisely/pvrusb2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On Monday 19 January 2009, Mauro Carvalho Chehab wrote:
> On Sat, 17 Jan 2009 19:09:51 +0100
>
> Carsten Meier <cm@xxxxxxxxxx> wrote:
> > Am Fri, 16 Jan 2009 02:47:50 -0200
> >
> > schrieb Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>:
> > > For usb devices, usb_make_path() provide a canonical name for the
> > > device. For PCI ones, we have pci_name() for the same function. in
> > > the case of pci devices, I suspect that all use pci_name(). We just
> > > need to use usb_make_path() at the usb ones.
> >
> > I looked at the sources for what string gets generated for bus_info by
> > usb_make_path(). If it gets used by pvrusb2, my problems are solved,
> > because it is constant across standby-wake-up-cycles. The pvrusb2's
> > implementation currently delivers "usb 7-2 address 6" here. "address
> > 6" corresponds to devnum which gets constantly increased, which results
> > in always changing strings here. Sorry for my unneccessary complaints.
>
> Mike, Thierry, Jean-Francois, Laurent and others:
>
> IMO, we should patch all usb drivers to use usb_make_path(). It will be
> more transparent to userspace, if all drivers provide the bus_info using
> the same notation. Comments?

According to the V4L2 spec, bus_info is the "location of the device in the 
system [...]. For example: 'PCI Slot 4'." Using usb_make_path() makes sense 
for USB devices (although this might still not be stable enough according to 
Carsten).

The V4L2 specification should be updated to mandate usage of usb_make_path() 
for USB devices.

Do you plan to submit a patch to fix/switch all the V4L2 USB drivers ?

Best regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux