Re: [PATCH 2/2 v2] gspca: Add MR97310A driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 Jan 2009 22:36:49 -0600
Kyle Guinn <elyk03@xxxxxxxxx> wrote:

> This patch adds support for USB webcams based on the MR97310A chip.
> It was tested with an Aiptek PenCam VGA+ webcam.

Hi Kyle,

I added your driver to my repository.

I just found a little bug. At line 250/251

	data[8] = 0x01;
	err_code = reg_w(gspca_dev, 10);

you set 9 values and you output 10 values.

BTW, as many of these USB control messages are constant, you should
better use static data or a table format (byte count, values)*.

Regards.

-- 
Ken ar c'hentan	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux