Hi Elliott, On Mon, Dec 16, 2024 at 08:44:59AM GMT, enh wrote: > On Thu, Aug 29, 2024 at 7:44 PM Alejandro Colomar <alx@xxxxxxxxxx> wrote: > > > @@ -285,6 +293,7 @@ is a file descriptor referring to a file other > > > > Would you mind checking this?: > > > > $ head -n11 <CONTRIBUTING.d/git > > Name > > Git - instructions for configuring git(1) > > > > Description > > git-diff(1), gitattributes(5) > > To produce useful hunk contexts in manual pages, we need to > > hack > > git(1)'s idea of a function name, and also to tell git what > > is a > > manual page. > > > > $ git config --global diff.man.xfuncname '^\.S[SHsh] > > .*$'; > > $ echo '*.[0-9]* diff=man' >>~/.config/git/attributes; > > > > It helps reviewing diffs for manual pages. :) > > > > ~/man-pages$ echo '*.[0-9]* diff=man' >>~/.git/attributes; You mistyped. It should be >>~/.config/git/attributes; not >>~/.git/attributes; > -bash: /usr/local/google/home/enh/.git/attributes: No such file or directory Hmmm, I should mkdir(1) first. > i assume this is meant to be > > ~/man-pages$ echo '*.[0-9]* diff=man' >>~/.gitattributes; > > instead? Nope; I think that won't work (per your patch, it seems it didn't). Would you mind creating the directories as appropriate, re-running that command, and resending the patch? (That will also help check that you ran it correctly.) Have a lovely day! Alex -- <https://www.alejandro-colomar.es/>
Attachment:
signature.asc
Description: PGP signature
