Hi Branden, On 2023-08-01 00:23, G. Branden Robinson wrote: > Hi Alex, > > At 2023-07-31T22:38:45+0200, Alejandro Colomar wrote: >> Ahh, I'll tell you my usual routine for reviewing patches, which will >> probably explain why I didn't notice: >> >> I first try to find the signature. If there's anything not generated by >> git(1) right below the "---" and before the list of files, I read that >> first (of course after the Subject) --that's where I would have expected >> your comment to go--. > > I am pretty confused. That's where I thought I put it. See screenshot. Sorry, I didn't use precise-enough language. I first try to find the "Signed-off-by". The "---" (3 dashes) below marks where the commit message ends, so anything after it --and before the diff itself-- is ignored by git(1). It's more or less the same as putting it in the email signature at the end, but I don't have to scroll to the very end. See an example: <https://lore.kernel.org/linux-man/7c0279c1-bbb8-c623-14d2-bb4d25966d28@xxxxxxxxxx/T/#mce831a3201a832ba3dc8517b934a42a5a5976e98> Cheers, Alex > >>>>> v3: Resubmitted; no change. A revision to "MR.sed" handles this >>>>> case. >> >> Okay; your prerogative. Free Britney! :-} > > Always happy to solve with sed what could be done interactively. :D Troo. :D > > Regards, > Branden -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
