Hi Branden, On 2023-07-31 22:19, G. Branden Robinson wrote: > Hi Alex, > > At 2023-07-31T21:56:27+0200, Alejandro Colomar wrote: >> Is this that you'll do it in MR sed, or that you forgot to fix it? :D > > Yes, that's what I meant to indicate by the v3 annotation at the end of > the mail. Ahh, I'll tell you my usual routine for reviewing patches, which will probably explain why I didn't notice: I first try to find the signature. If there's anything not generated by git(1) right below the "---" and before the list of files, I read that first (of course after the Subject) --that's where I would have expected your comment to go--. Then I may have a fast look at the patch before applying it, especially if I suspect I won't like it at a first glance. But if I trust the sender, I'll directly apply it; reading diffs in the email is not very pleasant, and git will color it nicely for me. And then I review the patch as applied. So, the only chance that I read personal messages like "This is just a resend" or "I didn't provide the diff; apply the attachment" is putting it there, right below the "---" that goes after your signature. That part is mostly ignored by git(1) --unless the content can be confused with a patch, I guess--. > >>> v3: Resubmitted; no change. A revision to "MR.sed" handles this >>> case. Okay; your prerogative. Free Britney! :-} Cheers, Alex > > Regards, > Branden -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
