Hi Zijun, On 2023-07-12 01:48, Zijun Zhao wrote: > Hi Alejandro, > Sorry for the late reply! No problem :-) > I made some changes(make the subject more > formal, add a blank line, respect the80-column right margin and use -u > to when doing git format-patch) and attached the patch below. Thanks! > But I am > a bit confused about semantic newlines. I think I already start on a > new line and use clause breaks to split long sentences? Do I > misunderstand something? Thank you! Here's your patch, modified to use semantic newlines: +The kernel accepts null for both time and timezone. +The timezone argument is ignored by glibc and musl, +and not passed to/from the kernel. +Android's bionic passes the timezone argument to/from the kernel, +but Android does not update the kernel timezone +based on the device timezone in Settings, +so the kernel's timezone is typically UTC. Does it make sense now? I'll also comment a few things about the patch: > +The kernel accepts null for both time and timezone. We should use the 'tv' and 'tz' identifiers. We should also use NULL. I suggest: The kernel accepts NULL for both .I tv and .IR tz . > +The timezone argument is ignored by glibc and musl, > +and not passed to/from the kernel. > +Android's bionic passes the timezone argument to/from the kernel, Could you give an example of why bionic differs from glibc and musl, and why it can be useful. It is mostly curiosity, but it might be useful to have it documented in the commit message. > +but Android does not update the kernel timezone > +based on the device timezone in Settings, > +so the kernel's timezone is typically UTC. Cheers, Alex -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
