should probably remove the "The compilation warning looks to be going away in glibc 2.17 see glibc commit 4b7634a5e03b0da6f8875de9d3f74c1cf6f2a6e8" above, since this patch fixes that, but leave the FIXME because it looks like there are more FIXMEs below? On Thu, May 18, 2023 at 4:27 PM Zijun Zhao <zijunzhao@xxxxxxxxxx> wrote: > > Hi there, > We are annotating settimeofday(), gettimeofday() and we will make tv > Nonnull if compilation warnings will > > result. But after checking > https://elixir.bootlin.com/linux/latest/source/kernel/time/time.c#L199 > nd https://elixir.bootlin.com/linux/latest/source/kernel/time/time.c#L224, > > we think tv is okay to be nullable. So we make the fix to make it more clear. > > Best, > > Zijun Zhao