Re: [PATCH 2/3] landlock.7: Document Landlock ABI v2 (file reparenting; kernel 5.19)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alex,

At 2023-02-25T02:10:22+0100, Alex Colomar wrote:
> On 2/23/23 09:48, Günther Noack wrote:
> > On Wed, Feb 22, 2023 at 08:36:37AM +0100, Mickaël Salaün wrote:
> > > On 2023-02-21T21:50:22.000+01:00, Günther Noack wrote:
> > > > +The availability of individual Landlock features is versioned through
> > > > +ABI levels:
> > > > +.TS
> > > > +box;
> > > > +ntb| ntb| lbx
> > > > +nt| nt| lbx.
> > > > +ABI	Kernel	Newly introduced access rights
> > > > +_	_	_
> > > > +1	5.13	LANDLOCK_ACCESS_FS_EXECUTE
> > > > +\^	\^	LANDLOCK_ACCESS_FS_WRITE_FILE
> > > > +\^	\^	LANDLOCK_ACCESS_FS_READ_FILE
> > > > +\^	\^	LANDLOCK_ACCESS_FS_READ_DIR
> > > > +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_DIR
> > > > +\^	\^	LANDLOCK_ACCESS_FS_REMOVE_FILE
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_CHAR
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_DIR
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_REG
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SOCK
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_FIFO
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_BLOCK
> > > > +\^	\^	LANDLOCK_ACCESS_FS_MAKE_SYM
> > > > +_	_	_
> > > > +2	5.19	LANDLOCK_ACCESS_FS_REFER
> > > > +.TE
> > > > +.PP
> > > 
> > > A line break would be nice here.
> > 
> > Added. (Used .sp 1 for that, as it is already used in the
> > mount_namespaces.7, ip.7 and other man pages.)
> 
[reorganized]
> I see:
> 
>        The  availability  of individual Landlock features is versioned
>        through ABI levels:
> 
>        ┌────┬────────┬────────────────────────────────────────────────┐
>        │ABI │ Kernel │ Newly introduced access rights                 │
>        ├────┼────────┼────────────────────────────────────────────────┤
>        │ 1  │  5.13  │ LANDLOCK_ACCESS_FS_EXECUTE                     │
>        │    │        │ LANDLOCK_ACCESS_FS_WRITE_FILE                  │
>        │    │        │ LANDLOCK_ACCESS_FS_READ_FILE                   │
>        │    │        │ LANDLOCK_ACCESS_FS_READ_DIR                    │
>        │    │        │ LANDLOCK_ACCESS_FS_REMOVE_DIR                  │
>        │    │        │ LANDLOCK_ACCESS_FS_REMOVE_FILE                 │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_CHAR                   │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_DIR                    │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_REG                    │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_SOCK                   │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_FIFO                   │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_BLOCK                  │
>        │    │        │ LANDLOCK_ACCESS_FS_MAKE_SYM                    │
>        ├────┼────────┼────────────────────────────────────────────────┤
>        │ 2  │  5.19  │ LANDLOCK_ACCESS_FS_REFER                       │
>        └────┴────────┴────────────────────────────────────────────────┘
>        To query the running kernel's Landlock ABI level, programs  may
>        pass  the LANDLOCK_CREATE_RULESET_VERSION flag to landlock_cre‐
>        ate_ruleset(2).
[reorganized]
> This sounds weird, but they are right that there seems to be a missing
> blank line.

Yes, they are.

> Could you explain why it's happening?

This is Savannah #49390.

https://savannah.gnu.org/bugs/?49390

It is fixed in groff 1.23.0.  Which, by the way, is at release candidate
3 now.  Final release may be this weekend, depending on Bertrand's
opinion of the changes I've made this week.[1]

> I'd expect the .PP to separate paragraphs with a blank, right?

It does, and it is, but you can't see it because groff 1.22.4 and
earlier table did not move the drawing position below the bottom box
border on nroff devices.

The '.sp 1' workaround (which is synonymous with plain '.sp') can be
removed when you feel groff 1.23.0 has spread sufficiently.

Regards,
Branden

[1] https://git.savannah.gnu.org/cgit/groff.git/log/

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux