Re: [PATCH] utime.2, utimensat.2: explicitly mention ctime changing.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Aug 2022, Alejandro Colomar wrote:
> Hi Neil and Jeff,
> 
> On 8/24/22 12:15, Jeff Layton wrote:
> > On Wed, 2022-08-24 at 11:21 +1000, NeilBrown wrote:
> >> utime and related calls always change the ctime.  It is worth making
> >> this explicit.
> >> This is clear from the code (vfs_utimes() in fs/utimes.c always sets
> >> ATTR_CTIME) and is documented in
> >>    https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
> >>
> >> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> >> ---
> >>   man2/utime.2     | 2 ++
> >>   man2/utimensat.2 | 3 +++
> >>   2 files changed, 5 insertions(+)
> >>
> >> diff --git a/man2/utime.2 b/man2/utime.2
> >> index 5338723574e2..7557d680afa3 100644
> >> --- a/man2/utime.2
> >> +++ b/man2/utime.2
> >> @@ -39,6 +39,8 @@ to the
> >>   fields of
> >>   .I times
> >>   respectively.
> >> +The status change time (ctime) will be set to the current time, even if the
> >> +other time stamps don't actually change.
> >>   .PP
> >>   If
> >>   .I times
> >> diff --git a/man2/utimensat.2 b/man2/utimensat.2
> >> index 11cf3ee24129..2abf8e196ee1 100644
> >> --- a/man2/utimensat.2
> >> +++ b/man2/utimensat.2
> >> @@ -101,6 +101,9 @@ If
> >>   .I times
> >>   is NULL, then both timestamps are set to the current time.
> >>   .\"
> >> +.PP
> >> +The status change time (ctime) will be set to the current time, even if the
> >> +other time stamps don't actually change.
> >>   .SS Permissions requirements
> >>   To set both file timestamps to the current time (i.e.,
> >>   .I times
> > 
> > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
> 
> Patch applied, with the tag.  Thank you both!

Thanks.

> 
> Cheers,
> Alex
> 
> P.S.: Please CC me in the patches, or I might not spot them.

I will in future, but you might like to update
https://www.kernel.org/doc/man-pages/patches.html to make it clear that
"either" isn't really wanted and "both" maintainers should get the patch.

NeilBrown


> 
> -- 
> Alejandro Colomar
> <http://www.alejandro-colomar.es/>
> 




[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux