Re: [PATCH] kcmp.2: still depends on kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 9, 2021 at 2:09 AM Alejandro Colomar (man-pages)
<alx.manpages@xxxxxxxxx> wrote:
> On 12/9/21 00:44, Jann Horn wrote:
> > The manpage claims that kcmp() is now available unconditionally. That's
> > not true; from kernel/Makefile:
> >
> >      obj-$(CONFIG_KCMP) += kcmp.o
> >
> > This new Kconfig flag is forced on by CONFIG_CHECKPOINT_RESTORE as
> > before, but also by CONFIG_DRM, which means that pretty much any kernel
> > built to support desktop systems will implicitly have it available.
> >
> > But if you compiled some kind of server/embedded kernel without DRM and
> > without CHECKPOINT_RESTORE, you'd have to flip on the expert config
> > option to get KCMP.
> >
> > Signed-off-by: Jann Horn <jannh@xxxxxxxxxx>
>
> Thanks!  Patch applied.

Oh, that was quick! Thanks.

> I slightly modified the patch for the following reason:
>
> man-pages(7):
>     Use semantic newlines
>         In the source of a manual page, new sentences  should  be
>         started  on new lines, and long sentences should be split
>         into lines at clause breaks (commas, semicolons,  colons,
>         and  so on).  This convention, sometimes known as "seman‐
>         tic newlines", makes it  easier  to  see  the  effect  of
>         patches,  which  often operate at the level of individual
>         sentences or sentence clauses.

Ah, thanks for the pointer. I'll try to remember it for next time...




[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux