On 12/30/20 11:43 PM, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
>
> On 12/30/20 10:41 PM, Alejandro Colomar wrote:
>> Glibc uses 'off64_t' instead of 'loff_t'.
>
> Okay.
>
>> This patch doesn't change the types in the code example,
>> because it uses the Linux syscall, and not the glibc wrapper.
>
> I think the example probably also needs fixing then. There's
> no longer a need for syscall(2) in this example, I think.
Hi Michael,
I thought the same, but glibc 2.26 is still supported,
and lacks the wrapper.
Would you change it already?
Thanks,
Alex
>
> Thanks,
>
> Michael
>
>> ......
>>
>> $ syscall='copy_file_range';
>> $ ret='ssize_t';
>> $ find glibc/ -type f -name '*.h' \
>> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
>> glibc/posix/unistd.h:1121:
>> ssize_t copy_file_range (int __infd, __off64_t *__pinoff,
>> int __outfd, __off64_t *__poutoff,
>> size_t __length, unsigned int __flags);
>>
>> Signed-off-by: Alejandro Colomar <alx.manpages@xxxxxxxxx>
>> ---
>> man2/copy_file_range.2 | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/man2/copy_file_range.2 b/man2/copy_file_range.2
>> index 1692aa44a..6f4708c4b 100644
>> --- a/man2/copy_file_range.2
>> +++ b/man2/copy_file_range.2
>> @@ -30,8 +30,8 @@ copy_file_range \- Copy a range of data from one file to another
>> .B #define _GNU_SOURCE
>> .B #include <unistd.h>
>> .PP
>> -.BI "ssize_t copy_file_range(int " fd_in ", loff_t *" off_in ,
>> -.BI " int " fd_out ", loff_t *" off_out ,
>> +.BI "ssize_t copy_file_range(int " fd_in ", off64_t *" off_in ,
>> +.BI " int " fd_out ", off64_t *" off_out ,
>> .BI " size_t " len ", unsigned int " flags );
>> .fi
>> .SH DESCRIPTION
>>
>
>
