On 12/28/20 9:06 PM, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > On Mon, 28 Dec 2020 at 19:24, Alejandro Colomar (man-pages) > <alx.manpages@xxxxxxxxx> wrote: >> >> Hi Michael & Gabriel, >> >> I disagree on a comment; see below. >> >> On 12/24/20 10:18 AM, Michael Kerrisk (man-pages) wrote: >>> Hello Gabriel, >>> >>> Thanks for the revisions! >>> >> [...] >>>> +.IP >>>> +When >>>> +.I arg2 >>>> +is set to >>>> +.BR PR_SYS_DISPATCH_ON , >>>> +.I arg3 >>>> +and >>>> +.I arg4 >>>> +respectively identify the >>>> +.I offset >>>> +and >>>> +.I length >>>> +of a single contiguous memory region in the process map >>>> +from where system calls are always allowed to be executed, >>>> +regardless of the switch variable >>>> +(Typically, this area would include the area of memory >>>> +containing the C library). >>> >>> s/)./.)/ >> >> That point is ending the full sentence starting at 'When', > > I see it the other. The piece in parentheses is a free-standing idea > that should be (parenthetical) sentence on its own. > > But, if that was not the case, your points below would hold. Hi Michael, I see; but there still isn't any separator between '... switch variable', and 'arg5 points to ...'. Would you then do?: [ +regardless of the switch variable_._ ] Or what? Thanks, Alex > > Thanks, > > Michael > > >> not just the >> sentence in parentheses. >> >> See <https://www.thepunctuationguide.com/terminal-points.html>. >> >> Quoting that, "The main sentence takes a period outside the closing >> parenthesis no matter what punctuation is included inside the >> parenthetical element.". So that you should be able to: s/(.*)// >> >> s/)./.)./ would be more correct, but I think ').' is enough. >> See my quotation above, which is a similar example :) >> >> I'd also s/Typically/typically/ >> >> Your thoughts? >> >> Thanks, >> >> Alex >> >>> >>>> +.I arg5 >>>> +points to a char-sized variable >>>> +that is a fast switch to enable/disable the mechanism >>>> +without the overhead of doing a system call. >>>> +The variable pointed by >> >> -- >> Alejandro Colomar >> Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ >> http://www.alejandro-colomar.es/ > > > -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/
