Hi Alex, On 9/4/20 3:43 PM, Alejandro Colomar wrote: >>From 90572d59a4f3b1986e57c0b32e14e4e68ecab716 Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> > Date: Thu, 3 Sep 2020 21:39:56 +0200 > Subject: [PATCH 09/34] sysctl.2: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory > > Signed-off-by: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> Patch applied. Thanks! Cheers, Michael > --- > man2/sysctl.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/sysctl.2 b/man2/sysctl.2 > index 65f79516d..161060490 100644 > --- a/man2/sysctl.2 > +++ b/man2/sysctl.2 > @@ -154,7 +154,7 @@ main(void) > size_t osnamelth; > int name[] = { CTL_KERN, KERN_OSTYPE }; > > - memset(&args, 0, sizeof(struct __sysctl_args)); > + memset(&args, 0, sizeof(args)); > args.name = name; > args.nlen = sizeof(name)/sizeof(name[0]); > args.oldval = osname; > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
