Hi Alex, On 9/4/20 3:42 PM, Alejandro Colomar wrote: >>From 791b2082c91de4fb49a1a46e9c11d294aac09050 Mon Sep 17 00:00:00 2001 > From: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> > Date: Thu, 3 Sep 2020 21:34:52 +0200 > Subject: [PATCH 08/34] poll.2: Use sizeof consistently > > Use ``sizeof`` consistently through all the examples in the following > way: > > - Use the name of the variable instead of its type as argument for > ``sizeof``. > > Rationale: > https://www.kernel.org/doc/html/v5.8/process/coding-style.html#allocating-memory This is another of those cases where I am inclined not to apply the patch. It feels to me like this reduces readability somewhat, since the very point is to allocate an array of pollfd structs. So, I think I won't apply this one. Thanks, Michael > Signed-off-by: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx> > --- > man2/poll.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/poll.2 b/man2/poll.2 > index 940c51da5..9b42822c0 100644 > --- a/man2/poll.2 > +++ b/man2/poll.2 > @@ -596,7 +596,7 @@ main(int argc, char *argv[]) > } > > num_open_fds = nfds = argc \- 1; > - pfds = calloc(nfds, sizeof(struct pollfd)); > + pfds = calloc(nfds, sizeof(*pfds)); > if (pfds == NULL) > errExit("malloc"); > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/
