Re: [PATCH v2 1/4] lirc.4: timeout reports are enabled by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/4/18 5:35 PM, Sean Young wrote:
> On Sun, Nov 04, 2018 at 04:54:22PM +0100, Michael Kerrisk (man-pages) wrote:
>> Hello Sean,
>>
> -snip-
>> So, I think the Linux 4.16+ text should read more like:
>>
>> [[
>> Since  Linux  4.16: each time the lirc device is opened, timeout
>> reports are by default enabled for the resulting file descriptor.
>> The LIRC_SET_REC_TIMEOUT operation can be used to disable (and,
>> if desired, to later re-enable) the timeout on the file descriptor.
>> ]]
>>
>> Seem okay?
>>
>>> The ioctl should really be removed.
>>>
>>>> Also, I read the Linux <= 4.15 text to mean that enabling or
>>>> disabling timeouts on one lirc FDs affects all currently open
>>>> FDs for that lirc device, as well as any subsequently opened 
>>>> devices. Is that correct?
>>>
>>> Yep.
>>
>> So, I think the pre-4.16 behavior could also be further clarified.
>> How about something like:
>>
>> [[
>> In Linux 4.15 and earlier: timeout reports are disabled
>> by  default,  and  enabling them on any file descriptor
>> associated with the lirc device has the effect of
>> enabling timeouts for all file descriptors referring to
>> that lirc device (until timeouts are disabled again).
>> ]]
>>
>> Seem okay?
> 
> Both are much clearer, thank you.  

Thanks. Amended.

Cheers,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/



[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux