Hi Michael, On Fri, Nov 02, 2018 at 12:43:41PM +0100, Michael Kerrisk (man-pages) wrote: > Hi Sean, > > On 11/02/2018 12:04 PM, Sean Young wrote: > > Signed-off-by: Sean Young <sean@xxxxxxxx> > > --- > > man4/lirc.4 | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/man4/lirc.4 b/man4/lirc.4 > > index 526d8432c..6e9a94a66 100644 > > --- a/man4/lirc.4 > > +++ b/man4/lirc.4 > > @@ -273,7 +273,14 @@ is 1) or disable > > .RI ( val > > is 0) timeout packages in > > .BR LIRC_MODE_MODE2 . > > -By default, timeout reports should be turned off. > > +Each time the > > +.BR lirc > > +device is opened, timeout reports are enabled for that > > +file descriptor since kernel release 4.16. > > +In earlier releases, timeout reports were disabled by default, and once > > +enabled, enabled for all > > +.BR lirc > > +file descriptors until turned off again. > > .TP > > .BR LIRC_SET_REC_CARRIER " (\fIint\fP)" > > Set the receive carrier frequency (Hz). > > I've applied this patch, and also tweaked the text somewhat. > Could you take a look please? Looks good I think. Thanks for fixing up my badly-phrases phrases. :) > One thing I'm still not clear about... Since kernel 4.16, > does enabling LIRC_SET_REC_TIMEOUT on an FD referring to a > lirc device cause all subsequently opened FDs on the lirc > device to have timeouts enabled? The existing text suggests > that, but it sounds like odd behavior. The LIRC_SET_REC_TIMEOUT feature is maintained per-fd, so for each newly opened fd, it is enabled. Sean
