Hi Heinrich, On Wed, May 21, 2014 at 8:19 AM, Heinrich Schuchardt <xypron.glpk@xxxxxx> wrote: > On 20.05.2014 09:36, Michael Kerrisk (man-pages) wrote: >> >> Hi Heinrich, >> >> On 05/19/2014 08:58 PM, Heinrich Schuchardt wrote: >>> >>> Hello Michael, >>> >>> the proposed new description of FAN_EVENT_NEXT is correct. >> >> >> Thanks for checking. I've added a Reviewed-by for you. >> >>> >>> Should FAN_EVENT_METADATA_LEN also be put into the section with macros? >>> >>> .B FAN_EVENT_METADATA_LEN >>> This macro returns the size of structure >>> .I fanotify_event_metadata >>> in bytes. >>> This is the minimum size (and currently the only size) of any event >>> metadata. >> >> >> I'm inclined not to, but I might be wrong. Is there a reason that >> user-space might use it? > > > FAN_EVENT_METADATA_LEN is the minimum size of a buffer used to read fanotify > events. Of cause the user may use sizeof to calculate it himself. Anyway > there is already some mentioning of FAN_EVENT_METADATA_LEN in fanotify.7. Okay - I added your text to fanotify(7). > You remarked inotify read buffers should be 4 byte aligned on some CPUs. > Shouldn't the same hold true for fanotify? Yes. So, it looks like a fix to fanotify(7) is required. Could you do that, please? Thanks, Michael -- To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
