Re: [PATCHES] Typos and questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Salut Nicolas,

On Sat, Sep 26, 2009 at 7:47 AM, Nicolas François
<nicolas.francois@xxxxxxxxxxxxxxx> wrote:
> Hello,
>
> Please find attached a set of patches.
> They should have a explicit name, and some have additional info in the
> header if needed.
>
> In my opinion, the patches starting with 0 can be applied as is (after a
> short review).

Yes. A great set of patches! Thanks! one or two comments below.

> The patches starting with a 9 need to be reviewed. Some of them are not
> patches, but questions:
>  * 904-tcp.7-list_separator.patch
>  * 919_cpuset.7-question.patch
>
> Please let me know if after a short look some of them should be reported
> first to bugzilla.

I will cover the 9* patches in a separate reply.

> The patches should apply to current git. The order should not be an issue.

I applied all of the 0* patches except for two.

009:
I see why you wanted to change this, but the change is not correct.
Really, "current processor" is best made into "host system". (The
domain name is a property of the system, not a process.)

018:

The first part of the patch isn't right (but again, I can see why you
wanted to malke a change). "waied for" is a qualify phrase for
"children". Adding a hyphen helps make that clear.

I applied this:

--- a/man2/sigaction.2
+++ b/man2/sigaction.2
@@ -304,10 +304,10 @@ The
 .I si_utime
 and
 .I si_stime
-fields do not include the times used by waited for children (unlike
+fields do not include the times used by waited-for children (unlike
 .BR getrusage (2)
 and
-.BR time (2).
+.BR time (2)).
 In kernels up to 2.6, and since 2.6.27, these fields report
 CPU time in units of
 .IR sysconf(_SC_CLK_TCK) .

Thanks very much for all of these!!

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Watch my Linux system programming book progress to publication!
http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Documentation]     [Netdev]     [Linux Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux