Re: [PATCH] slab: Fix too strict alignment check in create_cache()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 22, 2024 at 3:11 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
On Thu, 21 Nov 2024, John Paul Adrian Glaubitz wrote:
On Wed, 2024-11-20 at 13:46 +0100, Geert Uytterhoeven wrote:
On m68k, where the minimum alignment of unsigned long is 2 bytes:

Well, well, well, my old friend strikes again ;-).

These will always come up until we fix the alignment issue on m68k.

Hmmm. That patch you're replying too. Does it make the kernel source code
better or worse?

Touché ;-)

The same can be said about commit d811ac148f0afd2f ("virtchnl: fix
m68k build."): if you rely on a specific alignment, make sure to use
__aligned__ and/or struct padding.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux