Re: [PATCH v2] m68k: Define NR_CPUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24.09.24 10:07, David Hildenbrand wrote:
On 24.09.24 09:48, Geert Uytterhoeven wrote:
Hi David,

On Tue, Sep 24, 2024 at 9:34 AM David Hildenbrand <david@xxxxxxxxxx> wrote:
On 24.09.24 01:56, Guenter Roeck wrote:
v2: Instead of trying to make SPLIT_PTE_PTLOCKS depend on the
       existence of NR_CPUS, define NR_CPUS for m68k.

Okay, looks like we're cleaning up CONFIG_NR_CPUS for good.

I'm back from conference travel tomorrow; I'll then throw in the following
into cross compilers and fixup any other arch that needs attention:


diff --git a/include/linux/threads.h b/include/linux/threads.h
index 1674a471b0b4..e31715e6746b 100644
--- a/include/linux/threads.h
+++ b/include/linux/threads.h
@@ -13,8 +13,7 @@
     * bit of memory.  Use nr_cpu_ids instead of this except for static bitmaps.
     */
    #ifndef CONFIG_NR_CPUS
-/* FIXME: This should be fixed in the arch's Kconfig */
-#define CONFIG_NR_CPUS 1
+#error "CONFIG_NR_CPUS not defined"
    #endif

    /* Places which use this should consider cpumask_var_t. */

This is gonna trigger on almost all architectures if CONFIG_SMP=n.

Right, probably it's not as easy as:

Yeah, as assumed, Kconfig behaves weird if a symbol is not around. Let me think about this the upcoming weeks. Making split locks depend on SMP should make it work for now.

--
Cheers,

David / dhildenb





[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux