Re: [PATCH] m68k/mac: Revise PowerBook 500 series model name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, 17 Aug 2024, Geert Uytterhoeven wrote:

On Mon, Aug 12, 2024 at 8:56 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72
because that's their gestalt ID in MacOS. Hence, Linux describes them all
as "Powerbook 520". Change that to "Powerbook 500 series", which is more
accurate.

Cc: Joshua Thompson <funaho@xxxxxxxxx>
Cc: Stan Johnson <userm57@xxxxxxxxx>
Reported-by: Stan Johnson <userm57@xxxxxxxxx>
Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>

Thanks for your patch!

--- a/arch/m68k/mac/config.c
+++ b/arch/m68k/mac/config.c
@@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = {
                .floppy_type    = MAC_FLOPPY_OLD, /* SWIM 2 */
        }, {
                .ident          = MAC_MODEL_PB520,
-               .name           = "PowerBook 520",
+               .name           = "PowerBook 500 series",
                .adb_type       = MAC_ADB_PB2,
                .via_type       = MAC_VIA_QUADRA,
                .scsi_type      = MAC_SCSI_OLD,

This is a user-visible change, through /proc/hardware.
Do you know if any userspace relies on the old string value?


I did a search on sources.debian.org and didn't find anything. OTOH, a 
search for "powerbook" doesn't actually return Michael's packages that 
used to be available for powerbooks...

Anyway, I agree that /proc/hardware should remain stable, so please 
disregard this patch.

[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux