Hi Finn, On Mon, Aug 12, 2024 at 8:56 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
The PowerBook 520, 540 and 550 all have macintosh_config->ident == 72 because that's their gestalt ID in MacOS. Hence, Linux describes them all as "Powerbook 520". Change that to "Powerbook 500 series", which is more accurate. Cc: Joshua Thompson <funaho@xxxxxxxxx> Cc: Stan Johnson <userm57@xxxxxxxxx> Reported-by: Stan Johnson <userm57@xxxxxxxxx> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
Thanks for your patch!
--- a/arch/m68k/mac/config.c +++ b/arch/m68k/mac/config.c @@ -677,7 +677,7 @@ static struct mac_model mac_data_table[] = { .floppy_type = MAC_FLOPPY_OLD, /* SWIM 2 */ }, { .ident = MAC_MODEL_PB520, - .name = "PowerBook 520", + .name = "PowerBook 500 series", .adb_type = MAC_ADB_PB2, .via_type = MAC_VIA_QUADRA, .scsi_type = MAC_SCSI_OLD,
This is a user-visible change, through /proc/hardware. Do you know if any userspace relies on the old string value? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds