Re: [PATCH RFC v2 4/8] m68k: Handle arrivals of multiple signals correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

Thanks for your patch!

On Mon, Feb 5, 2024 at 3:32 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
From: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

When submitting a backport, please add lines like

    commit 4bb0bd81ce5e97092dfda6a106d414b703ec0ee8 upstream.

When we have several pending signals, have entered with the kernel
with large exception frame *and* have already built at least one
sigframe, regs->stkadj is going to be non-zero and regs->format/sr/pc
are going to be junk - the real values are in shifted exception stack
frame we'd built when putting together the first sigframe.

If that happens, subsequent sigframes are going to be garbage.
Not hard to fix - just need to find the "adjusted" frame first
and look for format/vector/sr/pc in it.

MSch: Minor v4.4 backport merge conflict fixes.

Please move this to "[MSch: ...] below...


Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Tested-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
Reviewed-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
Tested-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/YP2dBIAPTaVvHiZ6@xxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

... i.e. here.

Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>

Good.
Please add your SoB on all patches you handle, some lack it.

Thanks a lot for taking care of this!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux