Hi Michael,
On 12/10/23 04:21, Michael Schmitz wrote:
Hi Greg,
On 12/10/23 02:09, Greg Ungerer wrote:
I think this needs to be CONFIG_COLDFIRE is set and none of CONFIG_HAVE_CACHE_CB or
CONFIG_CACHE_D or CONFIG_CACHE_BOTH are set.
in the fec driver do the alloc_noncoherent and global cache flush
hack if:
COMFIG_COLDFIRE && (CONFIG_CACHE_D || CONFIG_CACHE_BOTH)
And then this becomes:
CONFIG_COLDFIRE && (CONFIG_HAVE_CACHE_CB || CONFIG_CACHE_D || CONFIG_CACHE_BOTH)
You appear to have dropped a '!' there ...
Not sure I follow. This is the opposite of the case above. The noncoherent alloc
and cache flush should be performed if ColdFire and any of CONFIG_HAVE_CACHE_CB,
CONFIG_CACHE_D or CONFIG_CACHE_BOTH are set - since that means there is data
caching involved.
Regards
Greg
