Re: [PATCH 5/6] net: fec: use dma_alloc_noncoherent for m532x

[Michael Schmitz <schmitzmic@xxxxxxxxx>]

Hi Greg,

On 12/10/23 02:09, Greg Ungerer wrote:
> I think this needs to be CONFIG_COLDFIRE is set and none of 
> CONFIG_HAVE_CACHE_CB or
> CONFIG_CACHE_D or CONFIG_CACHE_BOTH are set.
>
>
>
> > in the fec driver do the alloc_noncoherent and global cache flush
> > hack if:
> >
> > COMFIG_COLDFIRE && (CONFIG_CACHE_D || CONFIG_CACHE_BOTH)
>
> And then this becomes:
>
> CONFIG_COLDFIRE && (CONFIG_HAVE_CACHE_CB || CONFIG_CACHE_D || 
> CONFIG_CACHE_BOTH)

You appear to have dropped a '!' there ...

Cheers,

    Michael