Hi Finn,
On Fri, Sep 8, 2023 at 3:05 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
On Fri, 8 Sep 2023, Michael Schmitz wrote:
atariints.h already has some prototypes, so yes on that account.
atarihw.h only has inlines, but sound and time related prototypes could
be added there, too.
Geert's intentions might have been avoiding inclusion of all the
hardware specific data in those two files, but the only source file to
benefit from this is config.c (the other three already include
atariints.h and atarihw.h).
OTOH, considering this patch series adds a lot of other headers that
only contain prototypes, it might be better to keep to that pattern
everywhere.
I think Geert's intention may have been to avoid adding definitions to the
asm/foo.h headers shipped with "make headers_install". If that's the
intention, there would seem to be a mess to be cleaned up, for which I'm
partly to blame...
arch/m68k/include/asm/ is not shipped, (arch/m68k/include/uapi/asm/ is).
However, arch/m68k/include/asm/ is shared with the whole tree, while
only the core code under arch/m68k/ needs these definitions.
There is (are) definitely (an) opportunit{y,ies} for moving more stuff
around (from <asm/...> to "...", more extern declarations in C files, ...).
Not to mention the more substantial rework...
But Linux/m68k^WRome wasn't built in a decade neither... ;-)
And TBH, I also went for the "minimum amount of work" ;-)
(which didn't work out that well, yet another rabbit hole, as usual...).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
