Re: [PATCH 22/52] m68k: atari: Add and use "atari.h"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 8 Sep 2023, Michael Schmitz wrote:


atariints.h already has some prototypes, so yes on that account.

atarihw.h only has inlines, but sound and time related prototypes could 
be added there, too.

Geert's intentions might have been avoiding inclusion of all the 
hardware specific data in those two files, but the only source file to 
benefit from this is config.c (the other three already include 
atariints.h and atarihw.h).

OTOH, considering this patch series adds a lot of other headers that 
only contain prototypes, it might be better to keep to that pattern 
everywhere.


I think Geert's intention may have been to avoid adding definitions to the 
asm/foo.h headers shipped with "make headers_install". If that's the 
intention, there would seem to be a mess to be cleaned up, for which I'm 
partly to blame...



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux