Re: [PATCH RFC v3] m68k/q40: fix IO base selection for Q40 in pata_falcon.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 16 Aug 2023, Finn Thain wrote:

Given it's a platform device that's only ever instantiated once, you 
could just use the module-scope variable rather than device-scope.


I see that atari instantiates one platform device but q40 actually 
instantiates two ata ports, and each port has two drives. So it appears 
the module parameter would need to have 4 bits.

You could set ap->private_data to pdev. Then pata_falcon_data_xfer() can 
use pdev->id and sdev_target->id to find the relevant bit in the module 
parameter.



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux