On Wed, 16 Aug 2023, Michael Schmitz wrote:
Right - I also wonder whether using priv->swap_data to skip the bit test in the most likely case (no byte swapping) is actually worth it.
Given it's a platform device that's only ever instantiated once, you could just use the module-scope variable rather than device-scope. BTW, the patch description could state some of the implications for the default setting i.e. interoperability with the vendor operating system (and IDE disks from Atari Falcon I guess) as opposed to interoperability with everyone else.
I'll split this into bugfix and byte swap parts Where should this go - linux-ide for sure, but is Bartlomiej still the correct maintainer?
The latest MAINTAINERS file says, $ scripts/get_maintainer.pl -f drivers/ata/pata_falcon.c Sergey Shtylyov <s.shtylyov@xxxxxx> (reviewer:LIBATA PATA DRIVERS) Damien Le Moal <dlemoal@xxxxxxxxxx> (maintainer:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)) linux-ide@xxxxxxxxxxxxxxx (open list:LIBATA PATA DRIVERS) linux-kernel@xxxxxxxxxxxxxxx (open list) See also c4f9c8bbcc24 and fd86194aca1f.
