Hi Ben,
On Fri, Jun 16, 2023 at 5:47 PM Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
From: Ben Hutchings <benh@xxxxxxxxxx>
gas supports several different forms for .section for ELF targets,
including:
.section NAME [, "FLAGS"[, @TYPE[,FLAG_SPECIFIC_ARGUMENTS]]]
and:
.section "NAME"[, #FLAGS...]
In several places we use a mix of these two forms:
.section NAME, #FLAGS...
A current development snapshot of binutils (2.40.50.20230611) treats
this mixed syntax as an error.
Change to consistently use:
.section NAME, "FLAGS"
as is used elsewhere in the kernel.
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=m68k&ver=6.4%7Erc6-1%7Eexp1&stamp=1686907300&raw=1
Signed-off-by: Ben Hutchings <benh@xxxxxxxxxx>
Thanks for your patch! Consistency is good.
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. applied and queued.
---
These changes are compile-tested only.
I verified there is no difference in the generated object files with my
current toolchain (GNU assembler version 2.38 (m68k-linux-gnu)
using BFD version (GNU Binutils for Ubuntu) 2.38).
Do you think it's worthwhile to fast-track this for v6.5, or is it fine to
queue this for v6.6?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
