Hi! On Fri, 2023-06-16 17:36:10 +0200, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
gas supports several different forms for .section for ELF targets,
including:
.section NAME [, "FLAGS"[, @TYPE[,FLAG_SPECIFIC_ARGUMENTS]]]
and:
.section "NAME"[, #FLAGS...]
In several places we use a mix of these two forms:
.section NAME, #FLAGS...
A current development snapshot of binutils (2.40.50.20230611) treats
this mixed syntax as an error.
I stepped into this as well, and think it's a bad thing to break working code along with giving a bad error message: [mk all 2023-06-23 08:34:34] # AS arch/m68k/fpsp040/skeleton.o [mk all 2023-06-23 08:34:34] m68k-linux-gcc -Wp,-MMD,arch/m68k/fpsp040/.skeleton.o.d -nostdinc -I./arch/m68k/include -I./arch/m68k/include/generated -I./include -I./arch/m68k/include/uapi -I./arch/m68k/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/compiler-version.h -include ./include/linux/kconfig.h -D__KERNEL__ -fmacro-prefix-map=./= -D__ASSEMBLY__ -fno-PIE -m68040 -c -o arch/m68k/fpsp040/skeleton.o arch/m68k/fpsp040/skeleton.S [mk all 2023-06-23 08:34:34] arch/m68k/fpsp040/skeleton.S: Assembler messages: [mk all 2023-06-23 08:34:34] arch/m68k/fpsp040/skeleton.S:502: Error: junk at end of line, first unrecognized character is `#' [mk all 2023-06-23 08:34:34] arch/m68k/fpsp040/skeleton.S:508: Error: junk at end of line, first unrecognized character is `#' [mk all 2023-06-23 08:34:34] make[3]: *** [scripts/Makefile.build:374: arch/m68k/fpsp040/skeleton.o] Error 1 [mk all 2023-06-23 08:34:34] make[2]: *** [scripts/Makefile.build:494: arch/m68k/fpsp040] Error 2 [mk all 2023-06-23 08:34:34] make[1]: *** [scripts/Makefile.build:494: arch/m68k] Error 2 [mk all 2023-06-23 08:34:34] make: *** [Makefile:2026: .] Error 2
References: https://buildd.debian.org/status/fetch.php?pkg=linux&arch=m68k&ver=6.4%7Erc6-1%7Eexp1&stamp=1686907300&raw=1 Signed-off-by: Ben Hutchings <benh@xxxxxxxxxx>
As per pers.comm. with Geert: References: http://toolchain.lug-owl.de/laminar/jobs/linux-m68k-virt_defconfig/34 Tested-by: Jan-Benedict Glaw <jbglaw@xxxxxxxxxx> MfG, JBG --
Attachment:
signature.asc
Description: PGP signature
