On Jul 21 2023, Brad Boyer wrote:
On Fri, Jul 21, 2023 at 08:34:55AM +0200, Andreas Schwab wrote:
On Jul 20 2023, Matthew Wilcox wrote:
+static inline bool clear_bit_unlock_is_negative_byte(unsigned int nr,
+ volatile unsigned long *p)
+{
+ char result;
+ char mask = 1 << nr; /* nr guaranteed to be < 7 */
+
+ __asm__ __volatile__ ("eori %1, %2; smi %0"
Why are you using XOR if you want to clear a bit? If it operates on a
byte, why does it receive a pointer to long?
I presume the thing with byte is to try to save an extension word.
Why is this hardcoded in the function name?
--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
