Hi Michael,
Thanks for your patch!
On Thu, Jun 15, 2023 at 7:53 AM Christoph Hellwig <hch@xxxxxx> wrote:
On Thu, Jun 15, 2023 at 04:50:45PM +1200, Michael Schmitz wrote:
And as far as I can tell everything that is a __u32 here should
be an __be32 because it is a big endian on-disk format. Why
would you change only a single field?
Because that's all I needed, and wanted to avoid excess patch churn. Plus
(appeal to authority here :-)) it's in keeping with what Al Viro did when
the __be32 annotations were first added.
I can change all __u32 to __be32 and drop the comment if that's preferred.
That would be great!
I totally agree with Christoph.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds