Re: [PATCH v10 2/3] block: change annotation of rdb_CylBlocks in affs_hardblocks.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 15, 2023 at 03:08:36PM +1200, Michael Schmitz wrote:
+/* MSch 20230615: any field used by the Linux kernel must be
+ * annotated __be32! If any fields require increase to 64
+ * bit size, rdb_ID _must_ be changed!
+ */

This is a really weird comment.  If you change on-disk format it
is a different format and needs to be marked as such, sure.

And as far as I can tell everything that is a __u32 here should
be an __be32 because it is a big endian on-disk format.  Why
would you change only a single field?




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux