Re: [PATCH v3 4/6] fbdev: Include <linux/io.h> via <asm/fb.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 3, 2023, at 10:12, Thomas Zimmermann wrote:
Am 03.05.23 um 09:19 schrieb Javier Martinez Canillas:
Thomas Zimmermann <tzimmermann@xxxxxxx> writes:

There are countless examples where the above are not followed,
but to my best understanding the above it the preferred way to do it.

Where did youher this? I only know about this in the case of asm/io.h
vs. linux/io.h.


I understand that's the case too. I believe even checkpatch.pl complains
about it? (not that the script always get right, but just as an example).

Do you know if that's the general rule? If so, we might want to 
repurpose <asm/fbio.h> for the framebuffer I/O functions.

It's certainly the general trend across all of the kernel to have
drivers prefer including linux/*.h, and to move stuff from asm/*.h
to linux/*.h as it gets generalized across architectures.

     Arnd



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux