Re: [CFT][PATCH v2] net/8390: apne.c - read out and log PCMCIA cftable entries

[Michael Schmitz <schmitzmic@xxxxxxxxx>]

Hi Geert,


On 23/08/21 19:36, Geert Uytterhoeven wrote:
> > +
> > +       if ((len_cftuple = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256)) < 3) {
> > +               pr_cont("no cftable entry for card\n");
> > +               /* XXX: shouldn't we re-enable irq here? */
> > +       } else {
> > +               int i;
> > +
> > +               pr_info("CFTABLE_ENTRY tuple:\n");
> > +               for (i=0; i<len_cftuple; i++) {
> > +                       pr_cont("%hhx ", cftuple[i]);
> > +                       if (i > 0 && !(i % 10)) pr_cont("\n");
> > +               }
> > +               pr_cont("\n");
> print_hex_dump()?
Too true - I'll use that in the next iteration.

Cheers,

    Michael