Re: [CFT][PATCH v2] net/8390: apne.c - read out and log PCMCIA cftable entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Sun, Aug 22, 2021 at 5:11 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
Read the card's CISTPL_CFTABLE_ENTRY tuple, and log to the
kernel log buffer. This tuple ought to hold information
about the IO width of the card memory window that can be used
in autoprobing to detect 16 bit datapath cards.

CC: Debian/m68k <debian-68k@xxxxxxxxxxxxxxxx>
Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>

--- a/drivers/net/ethernet/8390/apne.c
+++ b/drivers/net/ethernet/8390/apne.c
@@ -127,6 +127,8 @@ struct net_device * __init apne_probe(int unit)

 #ifndef MANUAL_CONFIG
        char tuple[8];
+       char cftuple[258];
+       int len_cftuple = 0;
 #endif
        int err;

@@ -168,6 +170,20 @@ struct net_device * __init apne_probe(int unit)
                free_netdev(dev);
                return ERR_PTR(-ENODEV);
        }
+
+       if ((len_cftuple = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256)) < 3) {
+               pr_cont("no cftable entry for card\n");
+               /* XXX: shouldn't we re-enable irq here? */
+       } else {
+               int i;
+
+               pr_info("CFTABLE_ENTRY tuple:\n");
+               for (i=0; i<len_cftuple; i++) {
+                       pr_cont("%hhx ", cftuple[i]);
+                       if (i > 0 && !(i % 10)) pr_cont("\n");
+               }
+               pr_cont("\n");

print_hex_dump()?

+       }
 #endif

        pr_cont("ethernet PCMCIA card inserted\n");

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux