On Tue, Jun 1, 2021 at 11:02 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
On Mon, May 31, 2021 at 8:49 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>
Coldfire is now the only target that implements the clk_get()/clk_put()
helpers itself rather than using the common implementation.
Most coldfire variants only have two distinct clocks and use the clk
code purely for lookup. Change those over to use clkdev_lookup instead
but leave the custom clk interface for those two clocks.
Also leave the four SoCs that have gated clocks.
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Thanks for your patch!
--- a/arch/m68k/coldfire/m527x.c
+++ b/arch/m68k/coldfire/m527x.c
@@ -97,7 +86,7 @@ static void __init m527x_i2c_init(void)
/* set PAR_SCL to SCL and PAR_SDA to SDA */
par = readw(MCFGPIO_PAR_FECI2C);
par |= 0x0f;
- writew(par, MCFGPIO_PAR_FECI2C);
+ wm527x_clk_lookupritew(par, MCFGPIO_PAR_FECI2C);
As reported by the kernel test robot, this fails to compile.
Should probably just stay "write".
Yes, I already fixed that up yesterday. It appears I had accidentally inserted
a string with the middle mouse button, and building all defconfigs did
not catch this.
The fixed branch is at
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/log/?h=clkdev
and so far has not triggered any other warnings from the kernel built bot.
Arnd
