Re: [PATCH 4/7] m68k: coldfire: use clkdev_lookup on most coldfire

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

On Mon, May 31, 2021 at 8:49 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>

Coldfire is now the only target that implements the clk_get()/clk_put()
helpers itself rather than using the common implementation.

Most coldfire variants only have two distinct clocks and use the clk
code purely for lookup. Change those over to use clkdev_lookup instead
but leave the custom clk interface for those two clocks.

Also leave the four SoCs that have gated clocks.

Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for your patch!

--- a/arch/m68k/coldfire/m527x.c
+++ b/arch/m68k/coldfire/m527x.c

@@ -97,7 +86,7 @@ static void __init m527x_i2c_init(void)
        /*  set PAR_SCL to SCL and PAR_SDA to SDA */
        par = readw(MCFGPIO_PAR_FECI2C);
        par |= 0x0f;
-       writew(par, MCFGPIO_PAR_FECI2C);
+       wm527x_clk_lookupritew(par, MCFGPIO_PAR_FECI2C);

As reported by the kernel test robot, this fails to compile.
Should probably just stay "write".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux