Re: [PATCH] esp_scsi: Add support for FSC chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael!

Op wo 30 okt. 2019 om 02:06 schreef Michael Schmitz <schmitzmic@xxxxxxxxx>:
@@ -262,10 +263,11 @@ enum esp_rev {
     ESP100A    = 0x01,  /* NCR53C90A */
     ESP236     = 0x02,
     FAS236     = 0x03,
-    FAS100A    = 0x04,
-    FAST       = 0x05,
-    FASHME     = 0x06,
-    PCSCSI     = 0x07,  /* AM53c974 */
+    FSC        = 0x04,  /* NCR/Symbios Logic FSC */
+    FAS100A    = 0x05,
+    FAST       = 0x06,
+    FASHME     = 0x07,
+    PCSCSI     = 0x08,  /* AM53c974 */
I'm guessing that you've placed it here because of the esp->rev >= FAS236
tests that appear in a couple of places relating to sync transfer period.
Might be worth mentioning that in the commit log.

Good catch. I think these tests would need to be changed to esp->rev
 >=FSC to reflect the fact that the FSC has the same CONFIG3 settings as
the FAS236.

Um, no, that would break the FAS236. FSC is defined after FAS236. It's
import that its values is lower than FAS100A and greater or equal than
FAS236. And as I wrote in reply to Finn, I think PCSCSI falls in the
same category.

Kind regards,

Kars.



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux