On Fri, Sep 28, 2018 at 4:15 AM James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
On Thu, 2018-09-27 at 23:08 -0300, Leonardo Brás wrote:
Avoids building driver if 'make drivers/parisc/' is called and
CONFIG_PARISC is disabled.
Is that really a problem? The drivers/Makefile has this:
obj-$(CONFIG_PARISC) += parisc/
And you just overrode that by forcing the build. It's not even clear
we should refuse the build in that case; how would we know you don't
have a legitimate reason for the override?
Sorry I did not explained my reasons earlier. I sent everybody involved an
e-mail explaining the full reason of this change.
(For reference it's here: https://lkml.org/lkml/2018/10/3/707)
Signed-off-by: Leonardo Brás <leobras.c@xxxxxxxxx>
---
drivers/parisc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/parisc/Makefile b/drivers/parisc/Makefile
index 3cd5e6cb8478..80049d763aa0 100644
--- a/drivers/parisc/Makefile
+++ b/drivers/parisc/Makefile
@@ -24,5 +24,5 @@ obj-$(CONFIG_EISA) += eisa.o
eisa_enumerator.o eisa_eeprom.o
obj-$(CONFIG_SUPERIO) += superio.o
obj-$(CONFIG_CHASSIS_LCD_LED) += led.o
obj-$(CONFIG_PDC_STABLE) += pdc_stable.o
-obj-y += power.o
+obj-$(CONFIG_PARISC) += power.o
If we conclude the use case is legitimate, that's not enough: the two
inner symbols are PARISC only but CONFIG_EISA isn't.
You are right.
It worked for my needs because I am only building the drivers, and not
linking them. But i believe doing something like I did in zorro/Makefile
would fix this all. (For reference, https://lkml.org/lkml/2018/9/28/150 )
If you agree, I will send the next patchset with this change.
Thanks for your help!
Leonardo Bras
