On Thu, 2018-09-27 at 23:08 -0300, Leonardo Brás wrote:
Avoids building driver if 'make drivers/parisc/' is called and CONFIG_PARISC is disabled.
Is that really a problem? The drivers/Makefile has this: obj-$(CONFIG_PARISC) += parisc/ And you just overrode that by forcing the build. It's not even clear we should refuse the build in that case; how would we know you don't have a legitimate reason for the override? Signed-off-by: Leonardo Brás <leobras.c@xxxxxxxxx>
--- drivers/parisc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/parisc/Makefile b/drivers/parisc/Makefile index 3cd5e6cb8478..80049d763aa0 100644 --- a/drivers/parisc/Makefile +++ b/drivers/parisc/Makefile @@ -24,5 +24,5 @@ obj-$(CONFIG_EISA) += eisa.o eisa_enumerator.o eisa_eeprom.o obj-$(CONFIG_SUPERIO) += superio.o obj-$(CONFIG_CHASSIS_LCD_LED) += led.o obj-$(CONFIG_PDC_STABLE) += pdc_stable.o -obj-y += power.o +obj-$(CONFIG_PARISC) += power.o
If we conclude the use case is legitimate, that's not enough: the two inner symbols are PARISC only but CONFIG_EISA isn't. James
