Hi Vinod and Geert,
On Thu, Jun 28, 2018 at 04:39:13PM +0530, Vinod wrote:
On 28-06-18, 09:43, Geert Uytterhoeven wrote:
Hi Vinod,
On Thu, Jun 28, 2018 at 9:29 AM Vinod <vkoul@xxxxxxxxxx> wrote:
On 28-06-18, 08:50, Geert Uytterhoeven wrote:
On Thu, Jun 28, 2018 at 8:29 AM Vinod <vkoul@xxxxxxxxxx> wrote:
On 22-06-18, 11:44, Angelo Dureghello wrote:
obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o
obj-$(CONFIG_FSL_DMA) += fsldma.o
obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
+obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o
that makes kernel have two copies of common.o one in thsi driver and one
Does it? It's a common pattern in several Makefiles (e.g.
drivers/net/ethernet/8390/Makefile and drivers/scsi/Makefile)
won't each static symbol be part each one?
Remember, obj-y is a list, and IIRC it's filtered for duplicates.
What about when they are modules?
Same thing, you'll have fsl-edma-common.ko, and fsl-edma.ko and/or mcf-edma.ko.
Yeah that is right, I missed the list part
Ok, so if i understand, i'll fix all the Vinod points except the
Kconfig/makefile part that seems ok as is.
Vinod,
what do you think, am i near to a possible "accept" in a v6 or v7 ?
Or do you see any additional great job to do or other important
blocking points ?
Thanks,
regards,
Angelo Dureghello
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html