On Tue, 1 Nov 2016, Michael Schmitz wrote:
Hi Finn,
Am 01.11.2016 um 12:47 schrieb Finn Thain:
On Tue, 1 Nov 2016, Michael Schmitz wrote:
I had tried to set that bit in zorro_esp_slave_configure but had not
done a proper job of it - I'd only set esp->config3 and forgot to
set tp->esp_config3. Time to retest this ...
I don't think it's quite that easy - the ESP_CONFIG3_TENB bit needs
to be set for all targets if at least one SCSI-2 target is on the bus
and we allow dosconnecting, no?
I think ESP_CONFIG3_TENB is for FAS100A and FASHME. The bug here is on
ESP236 and FAS236, so ESP_CONFIG3_TBMS would be the relevant bit.
I stand corrected. Err... confused.
When setting ESP_CONFIG3_TBMS, should we set ESP_CONFIG3_GTM as well?
I think that depends entirely on the target. But it isn't relevant to the
bug at hand AFAICS.
--
The bit gets set when ESP_CONFIG2_SCSI2ENAB gets set (as in David's
patch) so we then need to avoid clobbering it, since ESP_CONFIG3_TBMS
== ESP_CONFIG3_EWIDE. I think we have to test for HME to avoid this
clash.
I'd want to set these bits for ESP236 and FAS236 only, so no clash with
HME. As you found out, ESP_CONFIG3_TBMS aka ESP_CONFIG3_EWIDE gets
clobbered on bus reset cleanup unconditionally.
Cheers,
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
