Hi Richard,
On Wed, May 14, 2014 at 10:57 PM, Richard Weinberger <richard@xxxxxx> wrote:
On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger <richard@xxxxxx> wrote:
But why this sudden #ifdef checks?
They are needed because in pgalloc.h you have:
#ifdef CONFIG_MMU
#include <asm/virtconvert.h>
#if defined(CONFIG_COLDFIRE)
#include <asm/mcf_pgalloc.h>
#elif defined(CONFIG_SUN3)
#include <asm/sun3_pgalloc.h>
#else
#include <asm/motorola_pgalloc.h>
#endif
And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions.
Therefore we need to define them such that the generic tlb.h versions will not clash
with yours.
Thanks for the clarification!
One problem which arises here is that me need to make sure that pgalloc.h is included before
tlb.h. Which kind of sucks.
Indeed.
arch/m68k/include/asm/mmu_context.h includes pgalloc.h, but not tlb.h.
Didn't check whether it gets it indirectly.
I'll move __pte/pmd_free_tlb from *_pgalloc.h into tlb.h to prevent this issue.
Are you fine with that?
As long as it compiles, I'm happy ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
