Am 14.05.2014 21:19, schrieb Geert Uytterhoeven:
On Wed, May 14, 2014 at 8:59 PM, Richard Weinberger <richard@xxxxxx> wrote:--- a/arch/m68k/include/asm/tlb.h +++ b/arch/m68k/include/asm/tlb.h @@ -1,19 +1,11 @@ #ifndef _M68K_TLB_H #define _M68K_TLB_H -/* - * m68k doesn't need any special per-pte or - * per-vma handling.. - */ -#define tlb_start_vma(tlb, vma) do { } while (0) -#define tlb_end_vma(tlb, vma) do { } while (0) -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) - -/* - * .. because we flush the whole mm when it - * fills up. - */ -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) +#ifdef CONFIG_MMU && !defined(CONFIG_COLDFIRE) && !defined(CONFIG_SUN3)Syntax error: #if defined(CONFIG_MMU) && ...
Whoops, thanks for pointing this out.
But why this sudden #ifdef checks?
They are needed because in pgalloc.h you have: #ifdef CONFIG_MMU #include <asm/virtconvert.h> #if defined(CONFIG_COLDFIRE) #include <asm/mcf_pgalloc.h> #elif defined(CONFIG_SUN3) #include <asm/sun3_pgalloc.h> #else #include <asm/motorola_pgalloc.h> #endif And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. Therefore we need to define them such that the generic tlb.h versions will not clash with yours. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
