Christian,
in the patches at first glance, only this, which makes me shiver:
+ ret = hid_add_device(hid_dev);
+ if (ret)
+ goto probe_err1;
Reminds me of fortran, are gotos legal in kernel source?
Nope, that's fine.
Explicitly allowed (and preferred) for that purpose (and a few select
other uses).
Nesting of if () else () branches for error unwinding would otherwise
look silly.
There's still some Real Programmers (Tm) out there :-)
Cheers,
Michael
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html