On Fri, Mar 29, 2013 at 9:06 AM, Christian T. Steigies <cts@xxxxxxxxxx> wrote:
On Fri, Mar 29, 2013 at 08:56:43AM +0100, Geert Uytterhoeven wrote:
On Fri, Mar 29, 2013 at 12:10 AM, Christian T. Steigies <cts@xxxxxxxxxx> wrote:
The HID drivers seem to be enabled in the official kernel, which runs on
kullervo, I don't seem to be able to switch off just the microsoft one.
Maybe by modifying the generic config, but I am afraid the magical package
building breaks again, genconfig.py does not run on my testing box, not sure
why. In Geert's tree, memcmp is not used in the driver, thats probably why
this one builds:
@@ -47,9 +46,9 @@
rdesc[559] = 0x45;
}
/* the same as above (s/usage/physical/) */
- if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
- !memcmp((char []){ 0x19, 0x00, 0x29, 0xff },
- &rdesc[94], 4)) {
+ if ((quirks & MS_RDESC_3K) && *rsize == 106 && rdesc[94] == 0x19 &&
+ rdesc[95] == 0x00 && rdesc[96] == 0x29 &&
+ rdesc[97] == 0xff) {
rdesc[94] = 0x35;
rdesc[96] = 0x45;
}
buildds) another way. kernel-package?
I reported that problem and it got fixed. Probably the fix never made it to
-stable?
commit 6b90466cfec2a2fe027187d675d8d14217c12d82
Author: Jiri Slaby <jslaby@xxxxxxx>
Date: Mon Nov 12 10:16:09 2012 +0100
HID: microsoft: do not use compound literal - fix build
Yes, I was not precise. The orig is what hid-microsoft looks like in
Debian's linux-source-3.8. The patched one is from Geert's tree, so it is
fixed in linux-m68k. Maybe I am missing something, but I don't see anything
The fix is present in upstream
$ git tag --contains 6b90466cfec2a2fe027187d675d8d14217c12d82
linux-3.7
linux-3.7-rc6
linux-3.7-rc7
linux-3.7-rc8
linux-3.7.1
linux-3.7.10
linux-3.7.2
linux-3.7.3
linux-3.7.4
linux-3.7.5
linux-3.7.6
linux-3.7.7
linux-3.7.8
linux-3.7.9
linux-3.8
linux-3.8-rc1
linux-3.8-rc2
linux-3.8-rc3
linux-3.8-rc4
linux-3.8-rc5
linux-3.8-rc6
linux-3.8-rc7
linux-3.8.1
linux-3.8.2
linux-3.8.3
linux-3.9-rc1
linux-3.9-rc2
linux-3.9-rc3
linux-3.9-rc4
How come it's broken in Debian's 3.8?
in the patches at first glance, only this, which makes me shiver:
+ ret = hid_add_device(hid_dev);
+ if (ret)
+ goto probe_err1;
Reminds me of fortran, are gotos legal in kernel source?
Nope, that's fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
